Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCVMM] Add support for latest API version #7778

Merged
merged 10 commits into from
Jul 31, 2024

Conversation

sidsinghms
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az scvmm --help

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 5, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️scvmm
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate scvmm vm disk add cmd scvmm vm disk add update parameter vhd_type: updated property choices from ['Dynamic', 'Static'] to ['Dynamic', 'Fixed']
⚠️ 1010 - ParaPropUpdate scvmm vm disk update cmd scvmm vm disk update update parameter vhd_type: updated property choices from ['Dynamic', 'Static'] to ['Dynamic', 'Fixed']

Copy link

Hi @sidsinghms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @sidsinghms,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 5, 2024

SCVMM

Copy link

github-actions bot commented Jul 5, 2024

For more info about extension versioning, please refer to Extension version schema

@yonzhan yonzhan requested a review from kairu-ms July 5, 2024 18:02
@yonzhan yonzhan requested a review from jsntcy July 5, 2024 18:03
@sidsinghms
Copy link
Member Author

Hi @sidsinghms, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Sure.

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jul 8, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 8, 2024

Please fix CI issues

@AllyW
Copy link
Member

AllyW commented Jul 10, 2024

⚠️Azure CLI Extensions Breaking Change Test

⚠️scvmm

rule
cmd_name
rule_message
suggest_message

⚠️ 1010 - ParaPropUpdate
scvmm vm disk add
cmd scvmm vm disk add update parameter vhd_type: updated property choices from ['Dynamic', 'Static'] to ['Dynamic', 'Fixed']

⚠️ 1010 - ParaPropUpdate
scvmm vm disk update
cmd scvmm vm disk update update parameter vhd_type: updated property choices from ['Dynamic', 'Static'] to ['Dynamic', 'Fixed']

@sidsinghms cmd arg property update count as interface change and please update version to be 1.1.0

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jul 10, 2024
@sidsinghms
Copy link
Member Author

Please fix CI issues

addressed👍

@sidsinghms
Copy link
Member Author

@yonzhan / @AllyW
I have addressed pipeline failures and updated the versioning.

Looking for the review and closure of this PR.
Kindly let me know If you need anything else from me.

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@AllyW AllyW added Docs and removed Docs labels Jul 18, 2024
… dev/siddhsingh/scvmm_july24_version

main merger
@sidsinghms
Copy link
Member Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 7778 in repo Azure/azure-cli-extensions

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit 0a40f5c into Azure:main Jul 31, 2024
19 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 1, 2024

[Release] Update index.json for extension [ scvmm ] : https://dev.azure.com/azclitools/release/_build/results?buildId=177803&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants